chore: Tweak withAttributes in Flow #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
changed the title
|
@pjfanning I think we should have this in 1.2.0-M1 , it's some kind of bug fix. |
|
Is there any way to add test coverage? Something like https://github.com/apache/pekko/blob/main/stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/FlowZipWithIndexSpec.scala#L60-L92 - which was added for #1525 |
|
Feel free to add it to m2, but actually the current fix not harm even without test. Otherwise ,it will cause problem when using in graphdsl as the zipwithIndex was implemented. |
|
I am uncomfortable with adding this in M1. There will be an M2 in a month or 2 and hopefully this can be added with some tests. |
He-Pin
force-pushed
the
withAttributes
branch
from
aff004e to
0e99b81
Compare
|
@pjfanning I have updated the code with test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
To avoid #1525 , I checked all the
Flow#withAttributesusage.Modification:
Move the
.withAttributes()inside thevia(...)Result: